From 141304ac783bfa094d773146e2a3509ea8980ad1 Mon Sep 17 00:00:00 2001
From: CarolinePascal <caroline8.pascal@gmail.com>
Date: Tue, 5 May 2026 11:54:03 +0200
Subject: [PATCH] fix(arguments order): reverting changes in arguments order in
 StreamingVideoEncoder

---
 src/lerobot/datasets/lerobot_dataset.py | 12 ++++++------
 src/lerobot/datasets/video_utils.py     |  3 +--
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/lerobot/datasets/lerobot_dataset.py b/src/lerobot/datasets/lerobot_dataset.py
index 110aac662..44d0c358d 100644
--- a/src/lerobot/datasets/lerobot_dataset.py
+++ b/src/lerobot/datasets/lerobot_dataset.py
@@ -251,14 +251,14 @@ class LeRobotDataset(torch.utils.data.Dataset):
                 streaming_enc = self._build_streaming_encoder(
                     self.meta.fps,
                     camera_encoder_config,
-                    self._encoder_threads,
                     encoder_queue_maxsize,
+                    encoder_threads,
                 )
             self.writer = DatasetWriter(
                 meta=self.meta,
                 root=self.root,
                 camera_encoder_config=camera_encoder_config,
-                encoder_threads=self._encoder_threads,
+                encoder_threads=encoder_threads,
                 batch_encoding_size=batch_encoding_size,
                 streaming_encoder=streaming_enc,
                 initial_frames=self.meta.total_frames,
@@ -300,14 +300,14 @@ class LeRobotDataset(torch.utils.data.Dataset):
     def _build_streaming_encoder(
         fps: int,
         camera_encoder_config: VideoEncoderConfig | None,
-        encoder_threads: int | None,
         encoder_queue_maxsize: int,
+        encoder_threads: int | None,
     ) -> StreamingVideoEncoder:
         return StreamingVideoEncoder(
             fps=fps,
             camera_encoder_config=camera_encoder_config,
-            encoder_threads=encoder_threads,
             queue_maxsize=encoder_queue_maxsize,
+            encoder_threads=encoder_threads,
         )
 
     # ── Metadata properties ───────────────────────────────────────────
@@ -698,7 +698,7 @@ class LeRobotDataset(torch.utils.data.Dataset):
         streaming_enc = None
         if streaming_encoding and len(obj.meta.video_keys) > 0:
             streaming_enc = cls._build_streaming_encoder(
-                fps, camera_encoder_config, encoder_threads, encoder_queue_maxsize
+                fps, camera_encoder_config, encoder_queue_maxsize, encoder_threads
             )
         obj.writer = DatasetWriter(
             meta=obj.meta,
@@ -802,7 +802,7 @@ class LeRobotDataset(torch.utils.data.Dataset):
         streaming_enc = None
         if streaming_encoding and len(obj.meta.video_keys) > 0:
             streaming_enc = cls._build_streaming_encoder(
-                obj.meta.fps, camera_encoder_config, encoder_threads, encoder_queue_maxsize
+                obj.meta.fps, camera_encoder_config, encoder_queue_maxsize, encoder_threads
             )
         obj.writer = DatasetWriter(
             meta=obj.meta,
diff --git a/src/lerobot/datasets/video_utils.py b/src/lerobot/datasets/video_utils.py
index 34360966f..b8d85b6b8 100644
--- a/src/lerobot/datasets/video_utils.py
+++ b/src/lerobot/datasets/video_utils.py
@@ -794,9 +794,8 @@ class StreamingVideoEncoder:
         self,
         fps: int,
         camera_encoder_config: VideoEncoderConfig | None = None,
-        encoder_threads: int | None = None,
-        *,
         queue_maxsize: int = 30,
+        encoder_threads: int | None = None,
     ):
         """
         Args: