admin/lerobot
1
0
Fork 0
mirror of https://github.com/huggingface/lerobot.git synced 2026-05-17 17:50:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: replace build_algorithm with make_algorithm for SACAlgorithmConfig and update related tests

Browse Source
This commit is contained in:
Khalil Meftah
2026-05-07 12:09:23 +02:00
parent f1bdd6744f
commit 29fc0c6d28
4 changed files with 58 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/rl/test_sac_algorithm.py
+4 -12
View File
@@ -501,25 +501,17 @@ def test_training_stats_generic_losses():
# ===========================================================================
# Registry-driven build_algorithm
# Registry-driven make_algorithm
# ===========================================================================
def test_build_algorithm_via_config():
"""SACAlgorithmConfig.build_algorithm should produce a working SACAlgorithm."""
def test_make_algorithm_builds_sac():
"""make_algorithm should look up the SAC class from the registry and instantiate it."""
sac_cfg = _make_sac_config()
algo_config = SACAlgorithmConfig.from_policy_config(sac_cfg)
algo_config.utd_ratio = 2
policy = GaussianActorPolicy(config=sac_cfg)
algorithm = algo_config.build_algorithm(policy)
algorithm = make_algorithm(cfg=algo_config, policy=policy)
assert isinstance(algorithm, SACAlgorithm)
assert algorithm.config.utd_ratio == 2
def test_make_algorithm_uses_build_algorithm():
"""make_algorithm should delegate to config.build_algorithm (no hardcoded if/else)."""
sac_cfg = _make_sac_config()
policy = GaussianActorPolicy(config=sac_cfg)
algorithm = make_algorithm(cfg=SACAlgorithmConfig.from_policy_config(sac_cfg), policy=policy)
assert isinstance(algorithm, SACAlgorithm)