From b0ab57cedc91874ea8d2ce879e1d170d398fa40e Mon Sep 17 00:00:00 2001 From: Pepijn Date: Tue, 9 Jun 2026 16:16:54 +0200 Subject: [PATCH] fix(streaming): make matrix sbatch --wrap body POSIX-sh safe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `sbatch --wrap` runs the wrapped body under /bin/sh (dash), which has no `set -o pipefail`, so every matrix job died on line 1 ("Illegal option -o pipefail") before reaching the benchmark. The command has no pipes, so drop the bashism and chain with `&&` (cd-guards the run) — fully POSIX-sh compatible. Runtime env expansion (${HF_HOME:-$SCRATCH/hf_home}) is preserved. Co-Authored-By: Claude Opus 4.8 (1M context) --- slurm/run_streaming_matrix.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/slurm/run_streaming_matrix.sh b/slurm/run_streaming_matrix.sh index 5e9ad6ae8..0958fedab 100755 --- a/slurm/run_streaming_matrix.sh +++ b/slurm/run_streaming_matrix.sh @@ -71,8 +71,8 @@ for SOURCE in $SOURCES; do --mem="$MEM" --time="$TIME" --output="$REPO_DIR/logs/%x-%j.out" \ $DEPFLAG \ ${ACCOUNT:+--account=$ACCOUNT} ${PARTITION:+--partition=$PARTITION} ${QOS:+--qos=$QOS} \ - --wrap "set -euo pipefail; cd '$REPO_DIR'; \ - export TOKENIZERS_PARALLELISM=false HF_HOME=\${HF_HOME:-\$SCRATCH/hf_home}; \ + --wrap "cd '$REPO_DIR' && \ + export TOKENIZERS_PARALLELISM=false && export HF_HOME=\${HF_HOME:-\$SCRATCH/hf_home} && \ $RUN benchmarks/streaming/benchmark_streaming.py \ --repo_id $REPO_ID $ROOTFLAG \ --mode $MODE --source $SOURCE --video_decode_device $DECODE \