mirror of
https://github.com/huggingface/lerobot.git
synced 2026-05-23 20:50:02 +00:00
refactor(annotate): drop dataset-level `tools` parquet column
PR 2 used to write a top-level ``tools`` column on every parquet shard holding the JSON schema for the ``say`` tool, broadcast identically across every row. That extends PR 1's schema for no real information gain — the schema is a fixed code constant, parquet's RLE/dict encoding collapses it on disk anyway, and HF/TRL chat-template consumers can just import the constant directly. PR 2 should fill in PR 1's existing schema, not add to it. So: - ``writer.py``: stop emitting the ``tools`` column. Strip any legacy ``tools`` column from older shards on rerun so the schema converges to v3.1. ``SAY_TOOL_SCHEMA`` stays as a public constant (now joined by ``DEFAULT_TOOLS = [SAY_TOOL_SCHEMA]``); chat-template policies and the visualizer import them directly. - ``test_writer.py``: replace the "tools column present" assertion with one that explicitly checks the column is absent, plus a new test asserting the constant's shape. - ``test_pipeline_recipe_render.py``: drop the tools-column read; assert it's not present in the rewritten parquet. - ``annotation_pipeline.mdx``: update the writer description to note the parquet stays small and the schema lives as a code constant. If multi-tool-set support ever becomes real (datasets with different tool inventories), the right home is ``meta/info.json["tools"]`` — adding it later is non-breaking; ripping out a parquet column already shipped is not. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -25,8 +25,14 @@ For every episode the writer:
|
||||
5. for each frame, materializes the sublist of event rows whose timestamp
|
||||
exactly equals that frame's timestamp,
|
||||
6. drops the legacy ``subtask_index`` column,
|
||||
7. adds a top-level ``tools`` column containing the JSON schema for ``say``,
|
||||
8. writes the parquet shard back in place.
|
||||
7. writes the parquet shard back in place.
|
||||
|
||||
The writer does NOT add a dataset-level ``tools`` column. Tool *calls* are
|
||||
emitted per-row via the existing ``tool_calls`` field on the v3.1 row
|
||||
struct (PR 1) for every speech atom. The tool *schema* (the description
|
||||
of the ``say`` function and its parameters) is a fixed code constant —
|
||||
``SAY_TOOL_SCHEMA`` below — and downstream chat-template consumers import
|
||||
it directly rather than reading a redundant per-row column.
|
||||
|
||||
Invariants enforced here (and re-checked by the validator):
|
||||
|
||||
@@ -38,7 +44,6 @@ Invariants enforced here (and re-checked by the validator):
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import logging
|
||||
from collections import defaultdict
|
||||
from collections.abc import Iterable, Sequence
|
||||
@@ -81,6 +86,19 @@ SAY_TOOL_SCHEMA: dict[str, Any] = {
|
||||
},
|
||||
},
|
||||
}
|
||||
"""Fixed JSON schema for the only tool the canonical recipe knows about.
|
||||
|
||||
Kept here as a code constant rather than written as a parquet column so
|
||||
the v3.1 schema (PR 1) doesn't need to grow a redundant broadcast field
|
||||
that holds the same value on every row of every dataset. Downstream
|
||||
chat-template consumers (Pi0.5 processor, lerobot-dataset-visualizer)
|
||||
import this directly. If multi-tool-set support ever becomes real, the
|
||||
right place is ``meta/info.json["tools"]`` — adding it later is
|
||||
non-breaking; ripping out a parquet column already shipped is not.
|
||||
"""
|
||||
|
||||
DEFAULT_TOOLS: list[dict[str, Any]] = [SAY_TOOL_SCHEMA]
|
||||
"""Convenience list for ``apply_chat_template(messages, tools=...)``."""
|
||||
|
||||
|
||||
def _row_persistent_sort_key(row: dict[str, Any]) -> tuple:
|
||||
@@ -286,8 +304,13 @@ class LanguageColumnsWriter:
|
||||
for name in table.column_names:
|
||||
if drop_old and name == "subtask_index":
|
||||
continue
|
||||
if name in (LANGUAGE_PERSISTENT, LANGUAGE_EVENTS, "tools"):
|
||||
if name in (LANGUAGE_PERSISTENT, LANGUAGE_EVENTS):
|
||||
continue # we'll re-add canonical versions
|
||||
# Strip any legacy ``tools`` column previously emitted by older
|
||||
# writers — the schema no longer uses it (constant lives in
|
||||
# SAY_TOOL_SCHEMA / DEFAULT_TOOLS).
|
||||
if name == "tools":
|
||||
continue
|
||||
cols.append(table.column(name))
|
||||
names.append(name)
|
||||
|
||||
@@ -304,14 +327,6 @@ class LanguageColumnsWriter:
|
||||
cols.extend([persistent_arr, events_arr])
|
||||
names.extend([LANGUAGE_PERSISTENT, LANGUAGE_EVENTS])
|
||||
|
||||
# Dataset-level tools column. Store the JSON schema as a string per
|
||||
# row (broadcast-identical, parquet dictionary-encodes it) — string
|
||||
# storage avoids requiring pa.json_() on every consumer.
|
||||
tools_json = json.dumps([SAY_TOOL_SCHEMA], sort_keys=True)
|
||||
tools_arr = pa.array([tools_json] * table.num_rows, type=pa.string())
|
||||
cols.append(tools_arr)
|
||||
names.append("tools")
|
||||
|
||||
return pa.Table.from_arrays(cols, names=names)
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user