improve serial_reading

src/lerobot/teleoperators/unitree_g1/exo_serial.py

@@ -38,19 +38,23 @@ def parse_raw16(line: bytes) -> list[int] | None:
 
 def read_raw_from_serial(ser) -> list[int] | None:
     """Read latest sample from serial; if buffer is backed up, keep only the newest."""
-    last = None
+    try:
-    while ser.in_waiting > 0:
+        last = None
-        b = ser.readline()
+        while ser.in_waiting > 0:
-        if not b:
+            b = ser.readline()
-            break
+            if not b:
-        raw16 = parse_raw16(b)
+                break
-        if raw16 is not None:
+            raw16 = parse_raw16(b)
-            last = raw16
+            if raw16 is not None:
-    if last is None:
+                last = raw16
-        b = ser.readline()
+        if last is None:
-        if b:
+            b = ser.readline()
-            last = parse_raw16(b)
+            if b:
-    return last
+                last = parse_raw16(b)
+        return last
+    except (OSError, serial.SerialException) as e:
+        logger.warning(f"Serial read error: {e}")
+        return None
 
 
 @dataclass
@@ -104,14 +108,20 @@ class ExoskeletonArm:
             logger.warning(f"failed to load calibration: {e}")
 
     def read_raw(self) -> list[int] | None:
-        if not self._ser:
+        if not self._ser or not self._ser.is_open:
             return None
         return read_raw_from_serial(self._ser)
 
-    def get_angles(self) -> dict[str, float]:
+    def get_angles(self, raw: list[int] | None = None) -> dict[str, float]:
+        """Convert raw ADC values to joint angles.
+
+        Args:
+            raw: Optional raw ADC values. If None, reads from serial.
+        """
         if not self.calibration:
             raise RuntimeError("exoskeleton not calibrated")
-        raw = self.read_raw()
+        if raw is None:
+            raw = self.read_raw()
         return {} if raw is None else exo_raw_to_angles(raw, self.calibration)
 
     def calibrate(self) -> None: