mirror of
https://github.com/huggingface/lerobot.git
synced 2026-05-14 08:09:45 +00:00
e963e5a0c4
* refactor: RL stack refactoring — RLAlgorithm, RLTrainer, DataMixer, and SAC restructuring * chore: clarify torch.compile disabled note in SACAlgorithm * fix(teleop): keyboard EE teleop not registering special keys and losing intervention state Fixes #2345 Co-authored-by: jpizarrom <jpizarrom@gmail.com> * fix: remove leftover normalization calls from reward classifier predict_reward Fixes #2355 * fix: add thread synchronization to ReplayBuffer to prevent race condition between add() and sample() * refactor: update SACAlgorithm to pass action_dim to _init_critics and fix encoder reference * perf: remove redundant CPU→GPU→CPU transition move in learner * Fix: add kwargs in reward classifier __init__() * fix: include IS_INTERVENTION in complementary_info sent to learner for offline replay buffer * fix: add try/finally to control_loop to ensure image writer cleanup on exit * fix: use string key for IS_INTERVENTION in complementary_info to avoid torch.load serialization error * fix: skip tests that require grpc if not available * fix(tests): ensure tensor stats comparison accounts for reshaping in normalization tests * fix(tests): skip tests that require grpc if not available * refactor(rl): expose public API in rl/__init__ and use relative imports in sub-packages * fix(config): update vision encoder model name to lerobot/resnet10 * fix(sac): clarify torch.compile status * refactor(rl): update shutdown_event type hints from 'any' to 'Any' for consistency and clarity * refactor(sac): simplify optimizer return structure * perf(rl): use async iterators in OnlineOfflineMixer.get_iterator * refactor(sac): decouple algorithm hyperparameters from policy config * update losses names in tests * fix docstring * remove unused type alias * fix test for flat dict structure * refactor(policies): rename policies/sac → policies/gaussian_actor * refactor(rl/sac): consolidate hyperparameter ownership and clean up discrete critic * perf(observation_processor): add CUDA support for image processing * fix(rl): correctly wire HIL-SERL gripper penalty through processor pipeline (cherry picked from commit9c2af818ff) * fix(rl): add time limit processor to environment pipeline (cherry picked from commitcd105f65cb) * fix(rl): clarify discrete gripper action mapping in GripperVelocityToJoint for SO100 (cherry picked from commit494f469a2b) * fix(rl): update neutral gripper action (cherry picked from commit9c9064e5be) * fix(rl): merge environment and action-processor info in transition processing (cherry picked from commit30e1886b64) * fix(rl): mirror gym_manipulator in actor (cherry picked from commitd2a046dfc5) * fix(rl): postprocess action in actor (cherry picked from commitc2556439e5) * fix(rl): improve action processing for discrete and continuous actions (cherry picked from commitf887ab3f6a) * fix(rl): enhance intervention handling in actor and learner (cherry picked from commitef8bfffbd7) * Revert "perf(observation_processor): add CUDA support for image processing" This reverts commit38b88c414c. * refactor(rl): make algorithm a nested config so all SAC hyperparameters are JSON-addressable * refactor(rl): add make_algorithm_config function for RLAlgorithmConfig instantiation * refactor(rl): add type property to RLAlgorithmConfig for better clarity * refactor(rl): make RLAlgorithmConfig an abstract base class for better extensibility * refactor(tests): remove grpc import checks from test files for cleaner code * fix(tests): gate RL tests on the `datasets` extra * refactor: simplify docstrings for clarity and conciseness across multiple files * fix(rl): update gripper position key and handle action absence during reset * fix(rl): record pre-step observation so (obs, action, next.reward) align in gym_manipulator dataset * refactor: clean up import statements * chore: address reviewer comments * chore: improve visual stats reshaping logic and update docstring for clarity * refactor: enforce mandatory config_class and name attributes in RLAlgorithm * refactor: implement NotImplementedError for abstract methods in RLAlgorithm and DataMixer * refactor: replace build_algorithm with make_algorithm for SACAlgorithmConfig and update related tests * refactor: add require_package calls for grpcio and gym-hil in relevant modules * refactor(rl): move grpcio guards to runtime entry points * feat(rl): consolidate HIL-SERL checkpoint into HF-style components Make `RLAlgorithmConfig` and `RLAlgorithm` `HubMixin`s, add abstract `state_dict()` / `load_state_dict()` for critic ensemble, target nets and `log_alpha`, and persist them as a sibling `algorithm/` component next to `pretrained_model/`. Replace the pickled `training_state.pt` with an enriched `training_step.json` carrying `step` and `interaction_step`, so resume restores actor + critics + target nets + temperature + optimizers + RNG + counters from HF-standard files. * refactor(rl): move actor weight-sync wire format from policy to algorithm * refactor(rl): update type hints for learner and actor functions * refactor(rl): hoist grpcio guard to module top in actor/learner * chore(rl): manage import pattern in actor (#3564) * chore(rl): manage import pattern in actor * chore(rl): optional grpc imports in learner; quote grpc ServicerContext types --------- Co-authored-by: Khalil Meftah <khalil.meftah@huggingface.co> * update uv.lock * chore(doc): update doc --------- Co-authored-by: jpizarrom <jpizarrom@gmail.com> Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
134 lines
4.1 KiB
Python
134 lines
4.1 KiB
Python
#!/usr/bin/env python
|
|
|
|
# Copyright 2026 The HuggingFace Inc. team. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import pytest
|
|
|
|
pytest.importorskip("datasets", reason="datasets is required (install lerobot[dataset])")
|
|
|
|
import torch # noqa: E402
|
|
from torch import Tensor # noqa: E402
|
|
|
|
from lerobot.rl.algorithms.base import RLAlgorithm # noqa: E402
|
|
from lerobot.rl.algorithms.configs import TrainingStats # noqa: E402
|
|
from lerobot.rl.trainer import RLTrainer # noqa: E402
|
|
from lerobot.utils.constants import ACTION, OBS_STATE # noqa: E402
|
|
|
|
|
|
class _DummyRLAlgorithmConfig:
|
|
"""Dummy config for testing."""
|
|
|
|
|
|
class _DummyRLAlgorithm(RLAlgorithm):
|
|
config_class = _DummyRLAlgorithmConfig
|
|
name = "dummy_rl_algorithm"
|
|
|
|
def __init__(self):
|
|
self.configure_calls = 0
|
|
self.update_calls = 0
|
|
|
|
def select_action(self, observation: dict[str, Tensor]) -> Tensor:
|
|
return torch.zeros(1)
|
|
|
|
def configure_data_iterator(
|
|
self,
|
|
data_mixer,
|
|
batch_size: int,
|
|
*,
|
|
async_prefetch: bool = True,
|
|
queue_size: int = 2,
|
|
):
|
|
self.configure_calls += 1
|
|
return data_mixer.get_iterator(
|
|
batch_size=batch_size,
|
|
async_prefetch=async_prefetch,
|
|
queue_size=queue_size,
|
|
)
|
|
|
|
def make_optimizers_and_scheduler(self):
|
|
return {}
|
|
|
|
def update(self, batch_iterator):
|
|
self.update_calls += 1
|
|
_ = next(batch_iterator)
|
|
return TrainingStats(losses={"dummy": 1.0})
|
|
|
|
def load_weights(self, weights, device="cpu") -> None:
|
|
_ = (weights, device)
|
|
|
|
def state_dict(self) -> dict[str, torch.Tensor]:
|
|
return {}
|
|
|
|
def load_state_dict(self, state_dict, device="cpu") -> None:
|
|
_ = (state_dict, device)
|
|
|
|
|
|
class _SimpleMixer:
|
|
def get_iterator(self, batch_size: int, async_prefetch: bool = True, queue_size: int = 2):
|
|
_ = (async_prefetch, queue_size)
|
|
while True:
|
|
yield {
|
|
"state": {OBS_STATE: torch.randn(batch_size, 3)},
|
|
ACTION: torch.randn(batch_size, 2),
|
|
"reward": torch.randn(batch_size),
|
|
"next_state": {OBS_STATE: torch.randn(batch_size, 3)},
|
|
"done": torch.zeros(batch_size),
|
|
"truncated": torch.zeros(batch_size),
|
|
"complementary_info": None,
|
|
}
|
|
|
|
|
|
def test_trainer_lazy_iterator_lifecycle_and_reset():
|
|
algo = _DummyRLAlgorithm()
|
|
mixer = _SimpleMixer()
|
|
trainer = RLTrainer(algorithm=algo, data_mixer=mixer, batch_size=4)
|
|
|
|
# First call builds iterator once.
|
|
trainer.training_step()
|
|
assert algo.configure_calls == 1
|
|
assert algo.update_calls == 1
|
|
|
|
# Second call reuses existing iterator.
|
|
trainer.training_step()
|
|
assert algo.configure_calls == 1
|
|
assert algo.update_calls == 2
|
|
|
|
# Explicit reset forces lazy rebuild on next step.
|
|
trainer.reset_data_iterator()
|
|
trainer.training_step()
|
|
assert algo.configure_calls == 2
|
|
assert algo.update_calls == 3
|
|
|
|
|
|
def test_trainer_set_data_mixer_resets_by_default():
|
|
algo = _DummyRLAlgorithm()
|
|
mixer_a = _SimpleMixer()
|
|
mixer_b = _SimpleMixer()
|
|
trainer = RLTrainer(algorithm=algo, data_mixer=mixer_a, batch_size=2)
|
|
|
|
trainer.training_step()
|
|
assert algo.configure_calls == 1
|
|
|
|
trainer.set_data_mixer(mixer_b, reset=True)
|
|
trainer.training_step()
|
|
assert algo.configure_calls == 2
|
|
|
|
|
|
def test_algorithm_optimization_step_contract_defaults():
|
|
algo = _DummyRLAlgorithm()
|
|
assert algo.optimization_step == 0
|
|
algo.optimization_step = 11
|
|
assert algo.optimization_step == 11
|