mirror of
https://github.com/huggingface/lerobot.git
synced 2026-08-01 05:59:44 +00:00
Lin Junrong
732a12108e
Four kinematic processor steps read the observation as
observation = self.transition.get(TransitionKey.OBSERVATION).copy()
if observation is None:
raise ValueError("Joints observation is require for computing robot kinematics")
so `.copy()` runs first and the guard below it is unreachable. A transition
without an observation raises `AttributeError: 'NoneType' object has no
attribute 'copy'` instead of the intended message.
That transition is not hypothetical: `RobotProcessorPipeline.process_action`
builds one with `create_transition(action=action)`, which sets
`TransitionKey.OBSERVATION` to None.
Reads the value first, checks it, then copies. Affects EEReferenceAndDelta,
InverseKinematicsEEToJoints, GripperVelocityToJoint and InverseKinematicsRLStep.
Adds a parametrised regression test covering all four; each fails with the
AttributeError if the fix is reverted.
Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
86 lines
3.3 KiB
Python
86 lines
3.3 KiB
Python
#!/usr/bin/env python
|
|
|
|
# Copyright 2025 The HuggingFace Inc. team. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import pytest
|
|
|
|
from lerobot.configs import FeatureType, PipelineFeatureType, PolicyFeature
|
|
from lerobot.processor.converters import create_transition
|
|
from lerobot.robots.so_follower.robot_kinematic_processor import (
|
|
EEReferenceAndDelta,
|
|
ForwardKinematicsJointsToEEAction,
|
|
ForwardKinematicsJointsToEEObservation,
|
|
GripperVelocityToJoint,
|
|
InverseKinematicsEEToJoints,
|
|
InverseKinematicsRLStep,
|
|
)
|
|
|
|
MOTOR_NAMES = ["shoulder_pan", "shoulder_lift", "elbow_flex", "wrist_flex", "wrist_roll", "gripper"]
|
|
EE_KEYS = {f"ee.{k}" for k in ["x", "y", "z", "wx", "wy", "wz", "gripper_pos"]}
|
|
|
|
|
|
def _joint_bucket(feature_type: FeatureType) -> dict[str, PolicyFeature]:
|
|
return {f"{n}.pos": PolicyFeature(type=feature_type, shape=(1,)) for n in MOTOR_NAMES}
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("step_cls", "bucket", "feature_type"),
|
|
[
|
|
(ForwardKinematicsJointsToEEAction, PipelineFeatureType.ACTION, FeatureType.ACTION),
|
|
(ForwardKinematicsJointsToEEObservation, PipelineFeatureType.OBSERVATION, FeatureType.STATE),
|
|
],
|
|
)
|
|
def test_fk_feature_schema(step_cls, bucket, feature_type):
|
|
features = {PipelineFeatureType.ACTION: {}, PipelineFeatureType.OBSERVATION: {}}
|
|
features[bucket] = _joint_bucket(feature_type)
|
|
out = step_cls(kinematics=None, motor_names=MOTOR_NAMES).transform_features(features)[bucket]
|
|
assert set(out) == EE_KEYS
|
|
assert {feature.type for feature in out.values()} == {feature_type}
|
|
|
|
|
|
EE_ACTION = dict.fromkeys(EE_KEYS, 0.0)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("step", "action"),
|
|
[
|
|
(
|
|
EEReferenceAndDelta(kinematics=None, end_effector_step_sizes={}, motor_names=MOTOR_NAMES),
|
|
dict(EE_ACTION),
|
|
),
|
|
(InverseKinematicsEEToJoints(kinematics=None, motor_names=MOTOR_NAMES), dict(EE_ACTION)),
|
|
(GripperVelocityToJoint(), {**EE_ACTION, "ee.gripper_vel": 0.0}),
|
|
(InverseKinematicsRLStep(kinematics=None, motor_names=MOTOR_NAMES), dict(EE_ACTION)),
|
|
],
|
|
ids=[
|
|
"ee_reference_and_delta",
|
|
"inverse_kinematics_ee_to_joints",
|
|
"gripper_velocity_to_joint",
|
|
"inverse_kinematics_rl_step",
|
|
],
|
|
)
|
|
def test_missing_observation_raises_value_error(step, action):
|
|
"""A transition without an observation must surface the documented ValueError.
|
|
|
|
`RobotProcessorPipeline.process_action` builds its transition with
|
|
`create_transition(action=...)`, which sets `TransitionKey.OBSERVATION` to None.
|
|
These steps used to call `.copy()` on that before the None check, so the guard
|
|
below them was unreachable and an AttributeError escaped instead.
|
|
"""
|
|
transition = create_transition(action=action)
|
|
|
|
with pytest.raises(ValueError, match="Joints observation"):
|
|
step(transition)
|