mirror of
https://github.com/huggingface/lerobot.git
synced 2026-08-08 17:39:44 +00:00
741005d719
Every docstring change for the API reference, on top of the infrastructure PR which contains none. Two halves: a repo-wide pass over what the renderer cannot handle, and `src/lerobot/robots/` taken to 100% as the worked example. **Renderer fixes, repo-wide.** Both of these render incorrectly the moment `[[autodoc]]` is on, and both were verified against a local build: - 24 Sphinx roles across three files. They are unsupported and render as literal `:pymeth:` text. Method references become doc-builder cross-references; the ones pointing at instance attributes become inline code, since attributes get no autodoc anchor and a cross-reference would be a dead link. - 43 `Attributes:` sections across 27 files. doc-builder parses a bare `Attributes:` as a synonym for `Parameters:` — `Robot`'s attributes rendered inside `<paramsdesc>`, presenting `config_class` and `name` to readers as constructor arguments when the actual parameter is `config`. Where the original carried no type, the type comes from the real class annotation rather than being invented. The four base classes every other module inherits from — `robot.py`, `teleoperator.py`, `motors_bus.py`, `camera.py` — are rewritten to the standard, since subclasses document only their deviations from that text. Three docstring errors corrected in passing: `Teleoperator.get_action` pointed at `observation_features`, which `Teleoperator` does not have; `send_feedback` documented a `Returns:` for a method returning `None`; and `config_class` was typed `RobotConfig` instead of `type[TeleoperatorConfig]`. **`robots/`, 109/306 -> 306/306.** The configuration dataclasses were the substantial part. Their fields were documented only with `#` comments above each field, which doc-builder cannot see: before this, `SO101FollowerConfig` rendered all eleven of its fields with not one description. Each config now carries an `Args:` block on the concrete registered class, covering inherited fields too, because doc-builder renders only a class's own docstring and several of these configs are thin multiple-inheritance shims whose body is `pass`. The inline comments are kept rather than removed, so fields stay annotated in the source as well as on the rendered page. Note this leaves each field described twice, and only the `Args:` block is checked against the signature by `make check-docstrings`, so the two can drift. Writing them turned up things worth stating plainly on the page rather than leaving in a comment: which configs have no serial port at all because they talk over a network or the cloud (Reachy 2, Unitree G1, LeKiwi's client, EarthRover), which manage their own calibration so `calibration_dir` does nothing, that OpenArm's default joint limits are deliberately tiny until `side` is set, and that reBot's `port` means a different thing depending on `can_adapter`. Two pre-existing docstring bugs that the doctest infrastructure surfaced are fixed here: `SerialMotorsBus` used `>>>` inside a ```bash block to show CLI output, which doctest read as Python and failed on with a SyntaxError, and `MotorsBus.torque_disabled`'s example referenced an undefined name. `ensure_safe_goal_position` gains a genuinely executing example so the doctest gate is not vacuous. **Gates ratcheted**, each of which the infrastructure PR left deliberately loose: - `check_docstrings.py`'s ignore list emptied — the ten objects it held all had bare `Attributes:` sections, now converted. - `check_config_docstrings.py`'s ignore list emptied — every registered robot config documents its port and calibration semantics. - `robots/` removed from the ruff `D` per-file-ignores, as are the two package-root files, whose one-line docstring issues are fixed here. D100 and D104 are ignored globally instead: they ask for a banner on every file and every `__init__.py`, which appears on no rendered page. - `interrogate` raised 52 -> 55 against a measured 55.3%. - The four `robots/` files carrying examples added to the doctest allowlist, which shipped empty. Verified: all 66 changed files under `src/lerobot/` are provably docstring-only (AST with docstrings stripped is byte-identical to main), no comment line is removed anywhere in `robots/`, and 708 tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
185 lines
6.2 KiB
Python
185 lines
6.2 KiB
Python
#!/usr/bin/env python
|
|
|
|
# Copyright 2024 The HuggingFace Inc. team. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import abc
|
|
import warnings
|
|
from typing import Any
|
|
|
|
from numpy.typing import NDArray # type: ignore # TODO: add type stubs for numpy.typing
|
|
|
|
from .configs import CameraConfig
|
|
|
|
|
|
class Camera(abc.ABC):
|
|
"""Base class for camera implementations.
|
|
|
|
Defines a standard interface for camera operations across different backends.
|
|
Subclasses must implement all abstract methods.
|
|
|
|
Manages basic camera properties (FPS, resolution) and core operations:
|
|
- Connection/disconnection
|
|
- Frame capture (sync/async/latest)
|
|
|
|
**Attributes**:
|
|
- **fps** (`int | None`) -- Configured frames per second.
|
|
- **width** (`int | None`) -- Frame width in pixels.
|
|
- **height** (`int | None`) -- Frame height in pixels.
|
|
"""
|
|
|
|
def __init__(self, config: CameraConfig):
|
|
"""Initialize the camera with the given configuration.
|
|
|
|
Args:
|
|
config: Camera configuration containing FPS and resolution.
|
|
"""
|
|
self.fps: int | None = config.fps
|
|
self.width: int | None = config.width
|
|
self.height: int | None = config.height
|
|
|
|
def __enter__(self):
|
|
"""
|
|
Context manager entry.
|
|
Automatically connects to the camera.
|
|
"""
|
|
self.connect()
|
|
return self
|
|
|
|
def __exit__(self, exc_type, exc_value, traceback) -> None:
|
|
"""
|
|
Context manager exit.
|
|
Automatically disconnects, ensuring resources are released even on error.
|
|
"""
|
|
self.disconnect()
|
|
|
|
def __del__(self) -> None:
|
|
"""
|
|
Destructor safety net.
|
|
Attempts to disconnect if the object is garbage collected without cleanup.
|
|
"""
|
|
try:
|
|
if self.is_connected:
|
|
self.disconnect()
|
|
except Exception: # nosec B110
|
|
pass
|
|
|
|
@property
|
|
@abc.abstractmethod
|
|
def is_connected(self) -> bool:
|
|
"""Check if the camera is currently connected.
|
|
|
|
Returns:
|
|
bool: True if the camera is connected and ready to capture frames,
|
|
False otherwise.
|
|
"""
|
|
pass
|
|
|
|
@staticmethod
|
|
@abc.abstractmethod
|
|
def find_cameras() -> list[dict[str, Any]]:
|
|
"""Detects available cameras connected to the system.
|
|
Returns:
|
|
List[Dict[str, Any]]: A list of dictionaries,
|
|
where each dictionary contains information about a detected camera.
|
|
"""
|
|
pass
|
|
|
|
@abc.abstractmethod
|
|
def connect(self, warmup: bool = True) -> None:
|
|
"""Establish connection to the camera.
|
|
|
|
Args:
|
|
warmup: If True (default), captures a warmup frame before returning. Useful
|
|
for cameras that require time to adjust capture settings.
|
|
If False, skips the warmup frame.
|
|
"""
|
|
pass
|
|
|
|
@abc.abstractmethod
|
|
def read(self) -> NDArray[Any]:
|
|
"""Capture and return a single frame from the camera synchronously.
|
|
|
|
This is a blocking call that will wait for the hardware and its SDK.
|
|
|
|
Returns:
|
|
np.ndarray: Captured frame as a numpy array.
|
|
"""
|
|
pass
|
|
|
|
@abc.abstractmethod
|
|
def async_read(self, timeout_ms: float = ...) -> NDArray[Any]:
|
|
"""Return the most recent new frame.
|
|
|
|
This method retrieves the latest frame captured by the background thread.
|
|
If a new frame is already available in the buffer (captured since the last call),
|
|
it returns it immediately.
|
|
|
|
It blocks up to `timeout_ms` only if the buffer is empty or if the latest frame
|
|
was already consumed by a previous `async_read` call.
|
|
|
|
Essentially, this method return the latest unconsumed frame, waiting if necessary
|
|
for a new one to arrive within the specified timeout.
|
|
|
|
Usage:
|
|
- Ideal for control loops where you want to ensure every processed frame
|
|
is fresh, effectively synchronizing your loop to the camera's FPS.
|
|
- Causes of a timeout usually include: very low camera FPS, heavy processing load,
|
|
or if the camera is disconnected.
|
|
|
|
Args:
|
|
timeout_ms: Maximum time to wait for a new frame in milliseconds.
|
|
Defaults to 200ms (0.2s).
|
|
|
|
Returns:
|
|
np.ndarray: Captured frame as a numpy array.
|
|
|
|
Raises:
|
|
TimeoutError: If no new frame arrives within `timeout_ms`.
|
|
"""
|
|
pass
|
|
|
|
def read_latest(self, max_age_ms: int = 500) -> NDArray[Any]:
|
|
"""Return the most recent frame captured immediately (Peeking).
|
|
|
|
This method is non-blocking and returns whatever is currently in the
|
|
memory buffer. The frame may be stale,
|
|
meaning it could have been captured a while ago (hanging camera scenario e.g.).
|
|
|
|
Usage:
|
|
Ideal for scenarios requiring zero latency or decoupled frequencies & when
|
|
we want a guaranteed frame, such as UI visualization, logging, or
|
|
non-critical monitoring.
|
|
|
|
Returns:
|
|
NDArray[Any]: The frame image (numpy array).
|
|
|
|
Raises:
|
|
TimeoutError: If the latest frame is older than `max_age_ms`.
|
|
NotConnectedError: If the camera is not connected.
|
|
RuntimeError: If the camera is connected but has not captured any frames yet.
|
|
"""
|
|
warnings.warn(
|
|
f"{self.__class__.__name__}.read_latest() is not implemented. "
|
|
"Please override read_latest(); it will be required in future releases.",
|
|
FutureWarning,
|
|
stacklevel=2,
|
|
)
|
|
return self.async_read()
|
|
|
|
@abc.abstractmethod
|
|
def disconnect(self) -> None:
|
|
"""Disconnect from the camera and release resources."""
|
|
pass
|