mirror of
https://github.com/huggingface/lerobot.git
synced 2026-08-08 17:39:44 +00:00
ef88d4e52b
* feat(train): parallel training engine with FSDP2, HSDP, and DCP checkpoints Replace the FSDP1 training path with a config-owned parallel-training engine: - Topology and runtime configs (--parallelism.*, --accelerator.*): dp_replicate x dp_shard degrees select single-process, DDP (unchanged default), FSDP2, or HSDP; mixed precision, first-class gradient accumulation, and FSDP/DDP tuning knobs are mirrored as plain dataclasses that build the accelerate objects at runtime, so every run is reproducible from its train_config.json alone. Accelerate env vars are guarded against configuring the engine behind the config system's back. - Declarative policy surface: policies declare FSDP2 wrap units (_fsdp_wrap_modules) and non-forward entry points (_fsdp_forward_methods); a shared engine resolves them around accelerator.prepare(). Context-parallel fields are reserved and validated to 1. - Checkpoints: selectable --checkpoint_format (safetensors | dcp | safetensors_dcp); the sharded optimizer channel is always DCP; two-phase resume (step+RNG before prepare, DCP model/optimizer after) reshards across GPU-topology changes; lerobot-convert-dcp merges DCP shards into a distributable model.safetensors offline. - Publishing: PreTrainedPolicy.push_model_to_hub is replaced by the free publish_trained_model (model + processors + card + train config, all-ranks gather with main-rank writes); PreTrainedPolicy._save_pretrained gathers state dicts internally, removing the state_dict= threading from save_pretrained. - lerobot_train is restructured around the engine: optimizer built before the single prepare() call, deferred weight load on DCP resumes, collective save_checkpoint with no call-site rank branches, dp-world-size-based sample accounting. Breaking changes: FSDP checkpoints from lerobot <= 0.6.x are not resumable (weights stay loadable via from_pretrained; pin lerobot==0.6.x to finish old runs); the `accelerate launch --config_file` yaml flow is superseded by the config flags; training autocast is owned exclusively by --accelerator.mixed_precision (policy.dtype only casts parameters). Also fixes: reward-model hub publishing crash (TypeError on extra kwargs). Verified by ~200 new CPU tests (config round-trips, checkpoint round-trips per format, two-phase resume, publisher contracts, converter equivalence, accelerate canaries), a 5-test 4-GPU suite (FSDP2 save/resume bit-exactness, HSDP/DDP loss parity, changed-topology resume, all-ranks save_pretrained, grad-accum equivalence), and end-to-end ACT (1/4/8 GPUs) + FastWAM 6B (FSDP2 + HSDP) training runs.
254 lines
11 KiB
Python
254 lines
11 KiB
Python
# Copyright 2024 The HuggingFace Inc. team. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import builtins
|
|
from pathlib import Path
|
|
from tempfile import TemporaryDirectory
|
|
from typing import Any, TypeVar
|
|
|
|
from huggingface_hub import HfApi
|
|
from huggingface_hub.utils import validate_hf_hub_args
|
|
|
|
from .constants import CHECKPOINTS_DIR
|
|
|
|
T = TypeVar("T", bound="HubMixin")
|
|
|
|
|
|
# Sharded-training resume artifacts (torch DCP shard dirs + shard files). Published model repos
|
|
# carry safetensors only, so publishing uploads exclude these — checkpoint pushes (which exist
|
|
# for resume, not distribution) deliberately do not.
|
|
def find_latest_hub_checkpoint(
|
|
repo_id: str,
|
|
*,
|
|
token: str | bool | None = None,
|
|
revision: str | None = None,
|
|
) -> str | None:
|
|
"""Repo-relative path of the most recent checkpoint in a training repo.
|
|
|
|
Training runs push checkpoints to ``checkpoints/<step>/`` (see
|
|
``push_checkpoint_to_hub``). This lists those step dirs and returns
|
|
``checkpoints/<highest-step>``, or ``None`` if the repo has no checkpoints.
|
|
|
|
Args:
|
|
repo_id (str): The Hub model repo to inspect.
|
|
token (str | bool | None): Hub authentication token. Defaults to None (the token
|
|
cached by `huggingface-cli login`).
|
|
revision (str | None): Repo revision to list. Defaults to None (the default branch).
|
|
|
|
Returns:
|
|
str | None: The repo-relative path `checkpoints/<highest-step>`, or None if the repo
|
|
has no checkpoints.
|
|
"""
|
|
files = HfApi().list_repo_files(repo_id=repo_id, repo_type="model", revision=revision, token=token)
|
|
prefix = f"{CHECKPOINTS_DIR}/"
|
|
steps = {
|
|
name for f in files if f.startswith(prefix) and (name := f[len(prefix) :].split("/", 1)[0]).isdigit()
|
|
}
|
|
if not steps:
|
|
return None
|
|
return f"{CHECKPOINTS_DIR}/{max(steps, key=int)}"
|
|
|
|
|
|
class HubMixin:
|
|
"""
|
|
A Mixin containing the functionality to push an object to the hub.
|
|
|
|
This is similar to huggingface_hub.ModelHubMixin but is lighter and makes less assumptions about its
|
|
subclasses (in particular, the fact that it's not necessarily a model).
|
|
|
|
The inheriting classes must implement '_save_pretrained' and 'from_pretrained'.
|
|
"""
|
|
|
|
def save_pretrained(
|
|
self,
|
|
save_directory: str | Path,
|
|
*,
|
|
repo_id: str | None = None,
|
|
push_to_hub: bool = False,
|
|
card_kwargs: dict[str, Any] | None = None,
|
|
**push_to_hub_kwargs,
|
|
) -> str | None:
|
|
"""
|
|
Save object in local directory.
|
|
|
|
Args:
|
|
save_directory (`str` or `Path`):
|
|
Path to directory in which the object will be saved.
|
|
push_to_hub (`bool`, *optional*, defaults to `False`):
|
|
Whether or not to push your object to the Huggingface Hub after saving it.
|
|
repo_id (`str`, *optional*):
|
|
ID of your repository on the Hub. Used only if `push_to_hub=True`. Will default to the folder name if
|
|
not provided.
|
|
card_kwargs (`Dict[str, Any]`, *optional*):
|
|
Additional arguments passed to the card template to customize the card.
|
|
push_to_hub_kwargs:
|
|
Additional key word arguments passed along to the [`~HubMixin.push_to_hub`] method.
|
|
Returns:
|
|
`str` or `None`: url of the commit on the Hub if `push_to_hub=True`, `None` otherwise.
|
|
"""
|
|
save_directory = Path(save_directory)
|
|
save_directory.mkdir(parents=True, exist_ok=True)
|
|
|
|
# save object (weights, files, etc.)
|
|
self._save_pretrained(save_directory)
|
|
|
|
# push to the Hub if required
|
|
if push_to_hub:
|
|
if repo_id is None:
|
|
repo_id = save_directory.name # Defaults to `save_directory` name
|
|
return self.push_to_hub(repo_id=repo_id, card_kwargs=card_kwargs, **push_to_hub_kwargs)
|
|
return None
|
|
|
|
def _save_pretrained(self, save_directory: Path) -> None:
|
|
"""
|
|
Overwrite this method in subclass to define how to save your object.
|
|
|
|
Args:
|
|
save_directory (`str` or `Path`):
|
|
Path to directory in which the object files will be saved.
|
|
"""
|
|
raise NotImplementedError
|
|
|
|
@classmethod
|
|
@validate_hf_hub_args
|
|
def from_pretrained(
|
|
cls: builtins.type[T],
|
|
pretrained_name_or_path: str | Path,
|
|
*,
|
|
force_download: bool = False,
|
|
resume_download: bool | None = None,
|
|
proxies: dict | None = None,
|
|
token: str | bool | None = None,
|
|
cache_dir: str | Path | None = None,
|
|
local_files_only: bool = False,
|
|
revision: str | None = None,
|
|
**kwargs,
|
|
) -> T:
|
|
"""
|
|
Download the object from the Huggingface Hub and instantiate it.
|
|
|
|
Args:
|
|
pretrained_name_or_path (`str`, `Path`):
|
|
- Either the `repo_id` (string) of the object hosted on the Hub, e.g. `lerobot/diffusion_pusht`.
|
|
- Or a path to a `directory` containing the object files saved using `.save_pretrained`,
|
|
e.g., `../path/to/my_model_directory/`.
|
|
revision (`str`, *optional*):
|
|
Revision on the Hub. Can be a branch name, a git tag or any commit id.
|
|
Defaults to the latest commit on `main` branch.
|
|
force_download (`bool`, *optional*, defaults to `False`):
|
|
Whether to force (re-)downloading the files from the Hub, overriding the existing cache.
|
|
proxies (`Dict[str, str]`, *optional*):
|
|
A dictionary of proxy servers to use by protocol or endpoint, e.g., `{'http': 'foo.bar:3128',
|
|
'http://hostname': 'foo.bar:4012'}`. The proxies are used on every request.
|
|
token (`str` or `bool`, *optional*):
|
|
The token to use as HTTP bearer authorization for remote files. By default, it will use the token
|
|
cached when running `huggingface-cli login`.
|
|
cache_dir (`str`, `Path`, *optional*):
|
|
Path to the folder where cached files are stored.
|
|
local_files_only (`bool`, *optional*, defaults to `False`):
|
|
If `True`, avoid downloading the file and return the path to the local cached file if it exists.
|
|
kwargs (`Dict`, *optional*):
|
|
Additional kwargs to pass to the object during initialization.
|
|
"""
|
|
raise NotImplementedError
|
|
|
|
@validate_hf_hub_args
|
|
def push_to_hub(
|
|
self,
|
|
repo_id: str,
|
|
*,
|
|
commit_message: str | None = None,
|
|
private: bool | None = None,
|
|
token: str | None = None,
|
|
branch: str | None = None,
|
|
create_pr: bool | None = None,
|
|
allow_patterns: list[str] | str | None = None,
|
|
ignore_patterns: list[str] | str | None = None,
|
|
delete_patterns: list[str] | str | None = None,
|
|
card_kwargs: dict[str, Any] | None = None,
|
|
) -> str | None:
|
|
"""
|
|
Upload model checkpoint to the Hub.
|
|
|
|
Use `allow_patterns` and `ignore_patterns` to precisely filter which files should be pushed to the hub. Use
|
|
`delete_patterns` to delete existing remote files in the same commit. See [`upload_folder`] reference for more
|
|
details.
|
|
|
|
Distributed contract: call on EVERY rank. `save_pretrained` runs on all ranks — for
|
|
sharded objects it can contain a collective gather (rank-gating it would deadlock) —
|
|
while repo creation and the upload happen on the main process only.
|
|
|
|
Args:
|
|
repo_id (`str`):
|
|
ID of the repository to push to (example: `"username/my-model"`).
|
|
commit_message (`str`, *optional*):
|
|
Message to commit while pushing.
|
|
private (`bool`, *optional*):
|
|
Whether the repository created should be private.
|
|
If `None` (default), the repo will be public unless the organization's default is private.
|
|
token (`str`, *optional*):
|
|
The token to use as HTTP bearer authorization for remote files. By default, it will use the token
|
|
cached when running `huggingface-cli login`.
|
|
branch (`str`, *optional*):
|
|
The git branch on which to push the model. This defaults to `"main"`.
|
|
create_pr (`boolean`, *optional*):
|
|
Whether or not to create a Pull Request from `branch` with that commit. Defaults to `False`.
|
|
allow_patterns (`List[str]` or `str`, *optional*):
|
|
If provided, only files matching at least one pattern are pushed.
|
|
ignore_patterns (`List[str]` or `str`, *optional*):
|
|
If provided, files matching any of the patterns are not pushed.
|
|
delete_patterns (`List[str]` or `str`, *optional*):
|
|
If provided, remote files matching any of the patterns will be deleted from the repo.
|
|
card_kwargs (`Dict[str, Any]`, *optional*):
|
|
Additional arguments passed to the card template to customize the card.
|
|
|
|
Returns:
|
|
`str` or `None`: The url of the commit of your object in the given repository, or
|
|
`None` on non-main ranks of a distributed run (only the main process uploads).
|
|
"""
|
|
# Lazy import: hub code must not import the distributed package at module load
|
|
# (configs -> hub is on the import path of lerobot.distributed itself).
|
|
from lerobot.distributed.utils import is_main_process
|
|
|
|
# Distributed contract: `save_pretrained` runs on EVERY rank — for sharded policies it
|
|
# contains a collective gather (rank-gating it would deadlock) and it writes into this
|
|
# rank's private tmpdir only on the main process. Repo creation and upload are then
|
|
# main-process-only.
|
|
if commit_message is None:
|
|
if "Policy" in self.__class__.__name__:
|
|
commit_message = "Upload policy"
|
|
elif "Config" in self.__class__.__name__:
|
|
commit_message = "Upload config"
|
|
else:
|
|
commit_message = f"Upload {self.__class__.__name__}"
|
|
|
|
with TemporaryDirectory(ignore_cleanup_errors=True) as tmp:
|
|
saved_path = Path(tmp) / repo_id
|
|
self.save_pretrained(saved_path, card_kwargs=card_kwargs)
|
|
if not is_main_process():
|
|
return None
|
|
api = HfApi(token=token)
|
|
repo_id = api.create_repo(repo_id=repo_id, private=private, exist_ok=True).repo_id
|
|
return api.upload_folder(
|
|
repo_id=repo_id,
|
|
repo_type="model",
|
|
folder_path=saved_path,
|
|
commit_message=commit_message,
|
|
revision=branch,
|
|
create_pr=create_pr,
|
|
allow_patterns=allow_patterns,
|
|
ignore_patterns=ignore_patterns,
|
|
delete_patterns=delete_patterns,
|
|
)
|