admin/lerobot
1
0
Fork 0
mirror of https://github.com/huggingface/lerobot.git synced 2026-05-21 19:49:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(arguments order): reverting changes in arguments order in StreamingVideoEncoder

Browse Source
This commit is contained in:
CarolinePascal
2026-05-05 11:54:03 +02:00
parent 9b3c752b64
commit 141304ac78
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lerobot/datasets/lerobot_dataset.py
+6 -6
View File
@@ -251,14 +251,14 @@ class LeRobotDataset(torch.utils.data.Dataset):
streaming_enc = self._build_streaming_encoder( streaming_enc = self._build_streaming_encoder(
self.meta.fps, self.meta.fps,
camera_encoder_config, camera_encoder_config,
self._encoder_threads,
encoder_queue_maxsize, encoder_queue_maxsize,
encoder_threads,
) )
self.writer = DatasetWriter( self.writer = DatasetWriter(
meta=self.meta, meta=self.meta,
root=self.root, root=self.root,
camera_encoder_config=camera_encoder_config, camera_encoder_config=camera_encoder_config,
encoder_threads=self._encoder_threads, encoder_threads=encoder_threads,
batch_encoding_size=batch_encoding_size, batch_encoding_size=batch_encoding_size,
streaming_encoder=streaming_enc, streaming_encoder=streaming_enc,
initial_frames=self.meta.total_frames, initial_frames=self.meta.total_frames,
@@ -300,14 +300,14 @@ class LeRobotDataset(torch.utils.data.Dataset):
def _build_streaming_encoder( def _build_streaming_encoder(
fps: int, fps: int,
camera_encoder_config: VideoEncoderConfig | None, camera_encoder_config: VideoEncoderConfig | None,
encoder_threads: int | None,
encoder_queue_maxsize: int, encoder_queue_maxsize: int,
encoder_threads: int | None,
) -> StreamingVideoEncoder: ) -> StreamingVideoEncoder:
return StreamingVideoEncoder( return StreamingVideoEncoder(
fps=fps, fps=fps,
camera_encoder_config=camera_encoder_config, camera_encoder_config=camera_encoder_config,
encoder_threads=encoder_threads,
queue_maxsize=encoder_queue_maxsize, queue_maxsize=encoder_queue_maxsize,
encoder_threads=encoder_threads,
) )
# ── Metadata properties ─────────────────────────────────────────── # ── Metadata properties ───────────────────────────────────────────
@@ -698,7 +698,7 @@ class LeRobotDataset(torch.utils.data.Dataset):
streaming_enc = None streaming_enc = None
if streaming_encoding and len(obj.meta.video_keys) > 0: if streaming_encoding and len(obj.meta.video_keys) > 0:
streaming_enc = cls._build_streaming_encoder( streaming_enc = cls._build_streaming_encoder(
fps, camera_encoder_config, encoder_threads, encoder_queue_maxsize fps, camera_encoder_config, encoder_queue_maxsize, encoder_threads
) )
obj.writer = DatasetWriter( obj.writer = DatasetWriter(
meta=obj.meta, meta=obj.meta,
@@ -802,7 +802,7 @@ class LeRobotDataset(torch.utils.data.Dataset):
streaming_enc = None streaming_enc = None
if streaming_encoding and len(obj.meta.video_keys) > 0: if streaming_encoding and len(obj.meta.video_keys) > 0:
streaming_enc = cls._build_streaming_encoder( streaming_enc = cls._build_streaming_encoder(
obj.meta.fps, camera_encoder_config, encoder_threads, encoder_queue_maxsize obj.meta.fps, camera_encoder_config, encoder_queue_maxsize, encoder_threads
) )
obj.writer = DatasetWriter( obj.writer = DatasetWriter(
meta=obj.meta, meta=obj.meta,
src/lerobot/datasets/video_utils.py
+1 -2
View File
@@ -794,9 +794,8 @@ class StreamingVideoEncoder:
self, self,
fps: int, fps: int,
camera_encoder_config: VideoEncoderConfig | None = None, camera_encoder_config: VideoEncoderConfig | None = None,
encoder_threads: int | None = None,
*,
queue_maxsize: int = 30, queue_maxsize: int = 30,
encoder_threads: int | None = None,
): ):
""" """
Args: Args: